NET 10 Update #2
Conversation
yurkinh
commented
Dec 8, 2025
yurkinh
commented
- Updated project files for .NET 10 compatibility
- Migrated to slnx
- Enabled source generations for the sample project
- cleanup
There was a problem hiding this comment.
Pull request overview
This PR migrates the FastPopups library and sample application from .NET 9 to .NET 10, updates the solution format from .sln to .slnx, and includes code cleanup.
- Migration of all target frameworks from
net9.0tonet10.0across platforms - Update of MAUI package versions from 9.x to 10.x
- Migration from traditional
.slnto modern.slnxsolution format - Cleanup of unused code and deprecated styles
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Sample/SampleApp.csproj | Updated target frameworks to net10.0 and package references to version 10.x; enabled XAML source generation |
| src/Lib/FastPopups.csproj | Updated target frameworks to net10.0, added EnableWindowsTargeting property, and updated package references to version 10.x |
| src/Sample/Views/NavigationStackPopup.xaml.cs | Changed from Application.Current?.MainPage to Application.Current?.Windows[0].Page to align with MAUI API changes |
| src/Sample/Resources/Styles/Styles.xaml | Removed deprecated Frame and ListView style definitions |
| src/Lib/Platforms/Android/MauiPopup.android.cs | Commented out unused variable and removed dead code |
| src/FastPopups.slnx | Added new XML-based solution format file |
| src/FastPopups.sln | Removed legacy solution file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Get the current page to show the popup | ||
| var currentPage = Application.Current?.MainPage; | ||
| var currentPage = Application.Current?.Windows[0].Page; |
There was a problem hiding this comment.
Accessing Application.Current?.Windows[0] without null or bounds checking could throw an IndexOutOfRangeException if the Windows collection is empty. Consider adding a check to ensure the collection has at least one element before accessing index 0:
var currentPage = Application.Current?.Windows.FirstOrDefault()?.Page;| <Setter Property="CornerRadius" Value="8" /> | ||
| <Setter Property="BackgroundColor" Value="{AppThemeBinding Light={StaticResource White}, Dark={StaticResource Black}}" /> | ||
| </Style> | ||
| </Style> |
There was a problem hiding this comment.
Trailing whitespace detected at the end of this line. Consider removing it for cleaner code formatting.
| </Style> | |
| </Style> |
1 participant
